Open
Conversation
alyashour
requested changes
Nov 26, 2025
alyashour
requested changes
Dec 2, 2025
alyashour
requested changes
Dec 4, 2025
Member
alyashour
left a comment
alyashour
left a comment
There was a problem hiding this comment.
Hello! Can you pls also remove the old callback comments.
include/ap1/control/control_node.hpp
Outdated
|
|
||
| #ifdef AP1_CONTROL_SUPPORT_TWIST | ||
| rclcpp::Publisher<geometry_msgs::msg::Twist>::SharedPtr twist_pub_; | ||
| rclcpp::TimerBase::SharedPtr twist_timer_; |
Contributor
Author
There was a problem hiding this comment.
It's showing that they've already been removed for me? Maybe you can't see my latest push?
include/ap1/control/control_node.hpp
Outdated
| #ifdef AP1_CONTROL_SUPPORT_ACKERMANN | ||
| rclcpp::Publisher<ackermann_msgs::msg::AckermannDriveStamped>::SharedPtr ackermann_pub_; | ||
| // timer for publishing ackermann outputs | ||
| rclcpp::TimerBase::SharedPtr timer_; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Request / Pull Request
Summary of Changes
Added ackermann_cmd output topic and twist output topic to the control node
Type of Change
Checklist (to be completed before review)
Passed test screenshots attacked to task in Notion Task Tracker
Related Issue / Task
Notes / Additional Context